Enable support for ebpf program type tracepoints #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanfern
force-pushed
the
sanfern-l3af-tracepoint-support
branch
4 times, most recently
from
7f01386 to
e0f8d49
Compare
Signed-off-by: Santhosh Fernandes <[email protected]>
sanfern
force-pushed
the
sanfern-l3af-tracepoint-support
branch
from
e0f8d49 to
668f371
Compare
Signed-off-by: sferna1 <[email protected]>
sanfern
force-pushed
the
sanfern-l3af-tracepoint-support
branch
from
c47e52b to
9fbfa4b
Compare
sanfern
requested review from
charleskbliu0,
jniesz,
dthaler,
ajayR006,
dalalkaran and
pmoroney
as code owners
sanfern
changed the title
|
Dependent on PR l3af-project/l3af-arch#113 |
.github/workflows/ci-e2e.yaml
Outdated
| @@ -33,7 +33,7 @@ jobs: | |||
| - name: Prep | |||
| run: | | |||
| sudo cp -r /home/runner/work/l3afd/l3afd /root | |||
| sudo git clone https://github.com/l3af-project/l3af-arch.git /root/l3af-arch | |||
| sudo git clone -b sanfern-e2e-add-probes https://github.com/sanfern/l3af-arch.git /root/l3af-arch | |||
There was a problem hiding this comment.
Please revert back once PR113 approved
kf/bpf.go
Outdated
| @@ -81,9 +81,6 @@ func NewBpfProgram(ctx context.Context, program models.BPFProgram, conf *config. | |||
| progMapFilePath = filepath.Join(conf.BpfMapDefaultPath, ifaceName, program.MapName) | |||
| } else if program.ProgType == models.TCType { | |||
| progMapFilePath = filepath.Join(conf.BpfMapDefaultPath, models.TCMapPinPath, ifaceName, program.MapName) | |||
| } else { | |||
| log.Error().Msgf("unsupported program type - %s", program.ProgType) | |||
| return nil | |||
| } | |||
There was a problem hiding this comment.
Is it suppose to add another check for the ProgType for tracepoints and keep the else for the type not supported?
There was a problem hiding this comment.
I agree, we should have an explicit list of types we support
There was a problem hiding this comment.
This block is for defining the progMapFilePath for pinning, when we were not supporting probe types. We wanted to explicitly throw errors for other than prog types of tc or xdp. Since we are supporting probes, we don't need prog maps and also we are not chaining. We don't want to error out here in case of probes.
pmoroney
reviewed
Jun 19, 2024
kf/bpf.go
Outdated
| @@ -81,9 +81,6 @@ func NewBpfProgram(ctx context.Context, program models.BPFProgram, conf *config. | |||
| progMapFilePath = filepath.Join(conf.BpfMapDefaultPath, ifaceName, program.MapName) | |||
| } else if program.ProgType == models.TCType { | |||
| progMapFilePath = filepath.Join(conf.BpfMapDefaultPath, models.TCMapPinPath, ifaceName, program.MapName) | |||
| } else { | |||
| log.Error().Msgf("unsupported program type - %s", program.ProgType) | |||
| return nil | |||
| } | |||
There was a problem hiding this comment.
I agree, we should have an explicit list of types we support
sanfern
force-pushed
the
sanfern-l3af-tracepoint-support
branch
2 times, most recently
from
033a13c to
116af47
Compare
pmoroney
previously approved these changes
Jun 26, 2024
Signed-off-by: sferna1 <[email protected]>
sanfern
force-pushed
the
sanfern-l3af-tracepoint-support
branch
from
116af47 to
a793619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for ebpf program type Tracepoints.
Issue #404