Update uprobe and uretprobe support #513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanfern
force-pushed
the
sanfern-uprobe-update
branch
2 times, most recently
from
d002d76 to
acca863
Compare
Signed-off-by: sanfern <[email protected]>
sanfern
force-pushed
the
sanfern-uprobe-update
branch
from
acca863 to
110bf20
Compare
sanfern
requested review from
charleskbliu0,
jniesz,
dalalkaran and
pmoroney
as code owners
| symbol = funcNames[0] | ||
| } else { | ||
| symbol = funcNames[len(funcNames)-1] | ||
| } |
There was a problem hiding this comment.
Can we make the above code as function, like symbol = getSymbol(hookName)? Therefore eliminate the if else below and keep the case statement for Uprobe and URetProbe separated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing support for uprobe and uretprobe type in eBPF programs