Skip to content

Commit

Permalink
feat: new image parsing on Environment page (#2785)
Browse files Browse the repository at this point in the history
related PR: lablup/backend.ai#2939

# Extended Image Information Support

This PR adds support for extended image information in the ImageList component and related translations. It introduces new fields and modifies the display of image details when the backend supports the 'extended-image-info' feature.

**Checklist:**
- [ ] Minimum required manager version: 24.09.1

## Changes

1. Updated `ImageListQuery` to include new fields: `namespace`, `base_image_name`, `tags`, and `version`.
2. Modified the ImageList component to conditionally render columns based on the `supportExtendedImageInfo` flag.
3. Added new translations for "Base image name" and "Tags" in multiple languages.
4. Updated the backend client to support the 'extended-image-info' feature for manager version 24.09.1 and above.

## Impact

- Users will see more detailed image information when using a compatible backend version.
- The image list will display new columns for base image name and tags when supported.
- Existing functionality is preserved for older backend versions.

## Review Notes

- Verify that the image list displays correctly with both old and new backend versions.
- Check that new translations are applied correctly in different languages.
- Ensure that sorting and filtering work properly with the new fields.

## How to test
1. Checkout core branch to `topic/10-22-feature_add_info_field_to_gql_image_schema` lablup/backend.ai#2993
2. Go to Environment page.

## What to check:
- [ ] Check the data is valid.
  - [ ]  Since 24.09.1: Full image path, Registry, Architecture, Namespace, Base image name, Version, Tags, Digest, Resource limit, Control.
  - [ ] Before 24.09.1: Full image path, Registry, Architecture, Name, Language, Version, Base, Constraints, Digest, Resource limit, Control.
- [ ] All data is highlightable by searching images.
- [ ] Sortable data works fine.

## Screenshots

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/88e5ad80-559a-4b41-a93a-5a08f3a4c062.png)
  • Loading branch information
agatha197 committed Nov 5, 2024
1 parent 3a72c18 commit b0d7ea2
Show file tree
Hide file tree
Showing 29 changed files with 674 additions and 265 deletions.
1 change: 1 addition & 0 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"Backendai",
"backendaiclient",
"backendaioptions",
"baseversion",
"cssinjs",
"cuda",
"FGPU",
Expand Down
Loading

0 comments on commit b0d7ea2

Please sign in to comment.