Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add config option that can hide custom resource allocation #1998

Merged
merged 1 commit into from
Nov 1, 2023
Merged

feat: add config option that can hide custom resource allocation #1998

merged 1 commit into from
Nov 1, 2023

Conversation

agatha197
Copy link
Contributor

resolves #1997

How to test:

  1. add allowCustomResourceAllocation option to config.toml
  2. Check the custom allocation is hidden when allowCustomResourceAllocation is false.

Hide custom allocation if allowCustomResourceAllocation is false.
image

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:enhance Add new features effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. urgency:3 Must be finished within a certain time frame. platform:general labels Oct 27, 2023
@agatha197 agatha197 added this to the 23.09 milestone Oct 27, 2023
@agatha197 agatha197 requested review from yomybaby and adrysn October 27, 2023 08:46
@agatha197 agatha197 self-assigned this Oct 27, 2023
@github-actions github-actions bot added the size:S 10~30 LoC label Oct 27, 2023
@aws-amplify-ap-northeast-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1998.d3g9cs6u59b8lw.amplifyapp.com

This was referenced Oct 27, 2023
Merged
Closed
inureyes
inureyes approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Update needed for backend.ai webserver.

@inureyes inureyes merged commit 2a59656 into main Nov 1, 2023
11 checks passed
@inureyes inureyes deleted the feature/add-allowCustomResourceAllocation branch November 1, 2023 04:51
@agatha197
Copy link
Contributor Author

LGTM.

Update needed for backend.ai webserver.

lablup/backend.ai#1666 already merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inureyes inureyes inureyes approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). platform:general size:S 10~30 LoC type:enhance Add new features urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Add allowCustomResourceAllocation that hide custom allocation on the session launcher.
2 participants
@agatha197 @inureyes