fix: limit number of characters of model service name #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
field:UI / UX
field:localization
size:XL
kyujin-cho
force-pushed
the
fix/service-name-too-long
branch
from
23110a8 to
16995cf
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.42% | 52/2153 |
| 🔴 | Branches | 1.42% | 16/1123 |
| 🔴 | Functions | 0.81% | 6/743 |
| 🔴 | Lines | 2.46% | 52/2116 |
Test suite run success
10 tests passing in 3 suites.
Report generated by 🧪jest coverage report action from 2e711da
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates model service constraint regex and its corresponding internationalization string to prevent model service session from being silently failing to be created. Due to the forming logic of model service session's
namefield (<Model Service Name>-<UUID>), the service name has to be smaller than 27 characters.Checklist: (if applicable)