Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add passwordless sudo user management UI #2005

Merged
merged 2 commits into from
Nov 1, 2023
Merged

feat: add passwordless sudo user management UI #2005

merged 2 commits into from
Nov 1, 2023

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Oct 30, 2023 •
edited
Loading

resolves #1978

What's changed

  • Query sudo_session_enabled
    image
  • Setting sudo_session_enabled
    image

How to test

  • Minimum manager version: 23.09.0b1.
  • Go to Users (credential) page -> check the user info and setting dialog.
  • Checklist
    • Can query sudo_session_enabled in the user info, user setting dialog.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:enhance Add new features effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. urgency:3 Must be finished within a certain time frame. platform:general impact:visible This change is visible to users. field:UI / UX labels Oct 30, 2023
@agatha197 agatha197 added this to the 23.09 milestone Oct 30, 2023
@agatha197 agatha197 requested a review from yomybaby October 30, 2023 05:00
@agatha197 agatha197 self-assigned this Oct 30, 2023
@github-actions github-actions bot added effort:normal Need to understand a few modules / some extent of contextual or historical information. urgency:4 As soon as feasible, implementation is essential. field:localization size:L 100~500 LoC labels Oct 30, 2023
@agatha197 agatha197 removed the urgency:4 As soon as feasible, implementation is essential. label Oct 30, 2023
@github-actions github-actions bot added the urgency:4 As soon as feasible, implementation is essential. label Oct 30, 2023
@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
2.41% (-0% 🔻)
 52/2161
🔴 Branches
1.41% (-0.01% 🔻)
 16/1133
🔴 Functions 0.81% 6/743
🔴 Lines
2.45% (-0% 🔻)
 52/2124

Test suite run success

10 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from ae833eb

@aws-amplify-ap-northeast-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2005.d3g9cs6u59b8lw.amplifyapp.com

inureyes
inureyes requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the compatible version.

src/lib/backend.ai-client-esm.ts Outdated
@@ -660,6 +660,9 @@ class Client {
if (this.isManagerVersionCompatibleWith('23.03.11')) {
this._features['model-serving'] = true;
}
if (this.isManagerVersionCompatibleWith('23.09.0b1')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beta check is not needed. please set it to 23.09.0

inureyes
inureyes approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit 7a6f0cb into main Nov 1, 2023
7 checks passed
@inureyes inureyes deleted the feature/passwordless-sudo-user branch November 1, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inureyes inureyes inureyes approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). effort:normal Need to understand a few modules / some extent of contextual or historical information. field:localization field:UI / UX impact:visible This change is visible to users. platform:general size:L 100~500 LoC type:enhance Add new features urgency:3 Must be finished within a certain time frame. urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Add passwordless sudo UI
2 participants
@agatha197 @inureyes