Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: set password to undefined when no change is desired. #2010

Merged
merged 1 commit into from
Nov 5, 2023
Merged

feature: set password to undefined when no change is desired. #2010

merged 1 commit into from
Nov 5, 2023

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 2, 2023

After lablup/backend.ai#1670 merged, you can test.

There are two changes

  • Set the password to undefined when no change is desired.
    • image
  • display the masked password if the password is set.
    • image

How to test

  • Create a registry with a username and password
    • You can see the **** in the password column of the created registry.
  • Click the "Edit" button in the registry. Check "비밀번호 변경" and leave the password field blank. Finally, click "Save".
    • You can see the empty password column of the registry.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:S 10~30 LoC label Nov 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements 3.83% 84/2192
🔴 Branches
4.38% (-0.01% 🔻)
 51/1165
🔴 Functions 1.73% 13/750
🔴 Lines 3.9% 84/2155

Test suite run success

11 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 2678482

@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2010.d3g9cs6u59b8lw.amplifyapp.com

@inureyes inureyes added type:fix Fix features that are not working effort:normal Need to understand a few modules / some extent of contextual or historical information. area:lib Library and SDK related issue. urgency:4 As soon as feasible, implementation is essential. platform:general impact:invisible This change is invisible to users (internal changes). comp:manager Related to Manager component labels Nov 5, 2023
@inureyes inureyes added this to the 23.09 milestone Nov 5, 2023
@inureyes inureyes self-requested a review November 5, 2023 05:05
inureyes
inureyes approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit b354148 into main Nov 5, 2023
15 checks passed
@inureyes inureyes deleted the feature/unset-value-with-null-in-cotainer-registry branch November 5, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inureyes inureyes inureyes approved these changes

Assignees

@yomybaby yomybaby

Labels
area:lib Library and SDK related issue. comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. impact:invisible This change is invisible to users (internal changes). platform:general size:S 10~30 LoC type:fix Fix features that are not working urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
2 participants
@yomybaby @inureyes