Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI with multiple types of accelerators #2012

Merged
merged 4 commits into from
Nov 5, 2023

Conversation

adrysn
Copy link
Member

@adrysn adrysn commented Nov 3, 2023

Some fixes for UI with multiple types of accelerators. The changes are far from optimal solutions, but rather points out that they require changes. Please check if the updates are compatible with other environments.

Broken accelerator allocation bar layout in the summary page
image

Broken resource monitor texts
image

Hide sFTP upload resource group from session launcher dialog
image

User's max session concurrency is displayed after 20 seconds
image

@adrysn adrysn self-assigned this Nov 3, 2023
@github-actions github-actions bot added the size:XL 500~ LoC label Nov 3, 2023
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2012.d3g9cs6u59b8lw.amplifyapp.com

@adrysn adrysn requested review from yomybaby and lizable November 3, 2023 16:25
@adrysn adrysn added action:need confirmation Needs confirmation. Request to reviewers. urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING impact:visible This change is visible to users. labels Nov 3, 2023
@adrysn adrysn added this to the 23.09 milestone Nov 3, 2023
- If the resource broker is not ready (when `globalThis`.backendaiclient
  is `undefined`), retry to get the `concurrency_max` after 2500 ms.
- Prevent silent failure in resource aggregation in the broker.
@adrysn adrysn requested review from inureyes and removed request for yomybaby and lizable November 5, 2023 04:28
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes added type:fix Fix features that are not working effort:hard Need to understand many components / a large extent of contextual or historical information. area:ux UI / UX issue. urgency:5 It is imperative that action be taken right away. platform:general field:UI / UX labels Nov 5, 2023
@inureyes inureyes merged commit 5fcd643 into main Nov 5, 2023
10 of 11 checks passed
@inureyes inureyes deleted the fix/ui-issues-with-multiple-types-of-accelerators branch November 5, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action:need confirmation Needs confirmation. Request to reviewers. area:ux UI / UX issue. effort:hard Need to understand many components / a large extent of contextual or historical information. field:UI / UX impact:visible This change is visible to users. platform:general size:XL 500~ LoC type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING urgency:5 It is imperative that action be taken right away.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants