Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change to setting.Pulgins to setting.OpensourcePlugins #2080

Merged
merged 4 commits into from
Dec 8, 2023
Merged

fix: Change to setting.Pulgins to setting.OpensourcePlugins #2080

merged 4 commits into from
Dec 8, 2023

Conversation

gee05053
Copy link
Contributor

@gee05053 gee05053 commented Dec 6, 2023 •
edited
Loading

This PR resolves #2079

스크린샷 2023-12-08 오전 9 33 23

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@gee05053 gee05053 added type:enhance Add new features effort:easy Need to understand only a specific region of codes (good first issue, easy). labels Dec 6, 2023
@gee05053 gee05053 self-assigned this Dec 6, 2023
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2080.d3g9cs6u59b8lw.amplifyapp.com

agatha197
agatha197 requested changes Dec 6, 2023
View reviewed changes
resources/i18n/en.json Outdated Show resolved Hide resolved
@gee05053 gee05053 requested a review from agatha197 December 6, 2023 04:27
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Dec 8, 2023
@gee05053 gee05053 requested a review from adrysn December 8, 2023 00:33
agatha197
agatha197 requested changes Dec 8, 2023
View reviewed changes
resources/i18n/de.json Outdated Show resolved Hide resolved
@gee05053 gee05053 requested a review from agatha197 December 8, 2023 05:13
agatha197
agatha197 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 merged commit 0d33e25 into main Dec 8, 2023
5 checks passed
@agatha197 agatha197 deleted the fix/change-Plugins-to-OpenSourcePlugins branch December 8, 2023 05:21
@inureyes inureyes changed the title Fix: Change to setting.Pulgins to setting.OpensourcePlugins fix: Change to setting.Pulgins to setting.OpensourcePlugins Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@gee05053 gee05053

Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). field:localization field:UI / UX size:L 100~500 LoC type:enhance Add new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: Change Plugins to OpenSource Function Plugins
2 participants
@gee05053 @agatha197