Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust support version check for main access key #2088

Merged

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Dec 8, 2023

⚠️ NOTE: Now(Dec 8, 2023 02:54PM KST), Backend.AI Core hasn't been released updated version of 23.09.

Since main_access_key field has been added from 23.09.7 in Core, We need to apply it to version checking statement.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@lizable lizable requested review from agatha197 and yomybaby December 8, 2023 05:55
@github-actions github-actions bot added the size:XS ~10 LoC label Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3.57% 97/2717
🔴 Branches 3.76% 61/1622
🔴 Functions 1.65% 15/908
🔴 Lines 3.63% 97/2673

Test suite run success

17 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 451162a

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2088.d3g9cs6u59b8lw.amplifyapp.com

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agatha197 agatha197 merged commit 1fcf5c9 into main Dec 8, 2023
8 checks passed
@agatha197 agatha197 deleted the fix/adjust-support-version-check-for-main-access-key branch December 8, 2023 06:06
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants