fix: missed prefix function usage in resource panel #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
Merge activity
|
### TL;DR Fixes an issue with the `_prefixFormat` method default parameter and optimizes CUDA GPU description formatting. ### What changed? - Fixed default parameter value in `_prefixFormat` method from `'0;'` to `'0'`. - Optimized the CUDA GPU description formatting using the `_prefixFormat` helper method. ### How to test? - Verify that the `_prefixFormat` method functions correctly with default and custom parameters. - Ensure that CUDA GPU descriptions are formatted as expected in the resource monitor component. ### Why make this change? The change corrects the default parameter value in the `_prefixFormat` method and streamlines the GPU description formatting for consistency and clarity. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
fix/missed-prefix-func-usage-in-resource-panel
branch
from
529e29d to
1206203
Compare
graphite-app
bot
deleted the
fix/missed-prefix-func-usage-in-resource-panel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes an issue with the
_prefixFormatmethod default parameter and optimizes CUDA GPU description formatting.What changed?
_prefixFormatmethod from'0;'to'0'._prefixFormathelper method.How to test?
_prefixFormatmethod functions correctly with default and custom parameters.Why make this change?
The change corrects the default parameter value in the
_prefixFormatmethod and streamlines the GPU description formatting for consistency and clarity.Checklist: (if applicable)