Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: change EndpointLLMChatCard close button color #2613

Merged

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Aug 7, 2024

Updated the style of the Button component in EndpointLLMChatCard to use token.colorIcon instead of token.colorBgMask for the icon color, ensuring consistency with design tokens.

Screenshot

image.png

image.png

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Aug 7, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:XS ~10 LoC label Aug 7, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@agatha197 agatha197 requested a review from ironAiken2 August 7, 2024 08:49
@agatha197 agatha197 added type:enhance Add new features area:ux UI / UX issue. urgency:1 If no other duties are available, volunteer to help. platform:general impact:visible This change is visible to users. field:UI / UX labels Aug 7, 2024 — with Graphite App
Copy link

github-actions bot commented Aug 7, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3.13% 180/5753
🔴 Branches 3.2% 123/3847
🔴 Functions 1.89% 36/1903
🔴 Lines 3% 169/5636

Test suite run success

64 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from e0b3ef1

Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

graphite-app bot commented Aug 7, 2024

Merge activity

Updated the style of the Button component in EndpointLLMChatCard to use token.colorIcon instead of token.colorBgMask for the icon color, ensuring consistency with design tokens.

### Screenshot

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/7ae74ade-e891-4348-86df-2b073eb19fde.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/ab1799fa-d390-4a2b-95c5-c2d5757bf685.png)

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@ironAiken2 ironAiken2 force-pushed the style/change-EndpointLLMChatCard-close-button-color branch from 2d28aa3 to e0b3ef1 Compare August 7, 2024 09:44
@graphite-app graphite-app bot merged commit e0b3ef1 into main Aug 7, 2024
6 checks passed
@graphite-app graphite-app bot deleted the style/change-EndpointLLMChatCard-close-button-color branch August 7, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ux UI / UX issue. field:UI / UX impact:visible This change is visible to users. platform:general size:XS ~10 LoC type:enhance Add new features urgency:1 If no other duties are available, volunteer to help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants