Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Gaudi 2 icon #2630

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Aug 13, 2024

  • agent summary

image.png

  • agent

image.png

  • session list

image.png

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Aug 13, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

agatha197 commented Aug 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added area:ux UI / UX issue. size:XS ~10 LoC labels Aug 13, 2024
@agatha197 agatha197 marked this pull request as draft August 13, 2024 07:57
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from 121ca7d to c33b69f Compare August 13, 2024 08:24
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Aug 13, 2024
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from c33b69f to db7a321 Compare August 13, 2024 08:30
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Aug 13, 2024
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from db7a321 to 69bbe8f Compare August 13, 2024 08:32
@agatha197 agatha197 marked this pull request as ready for review August 13, 2024 08:32
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from 69bbe8f to cbc2652 Compare August 13, 2024 08:50
@github-actions github-actions bot added area:lib Library and SDK related issue. area:i18n Localization size:XL 500~ LoC and removed size:M 30~100 LoC labels Aug 13, 2024
@agatha197 agatha197 marked this pull request as draft August 13, 2024 08:54
@agatha197 agatha197 force-pushed the feature/support-gaudi-2 branch from aedd145 to 2224ca5 Compare August 13, 2024 08:56
@agatha197 agatha197 marked this pull request as ready for review August 13, 2024 08:57
@agatha197 agatha197 requested a review from rapsealk August 13, 2024 08:58
resources/icons/Intel-gaudi.svg Outdated Show resolved Hide resolved
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from cbc2652 to 76d119e Compare August 13, 2024 09:22
@github-actions github-actions bot added size:M 30~100 LoC and removed size:XL 500~ LoC labels Aug 13, 2024
@rapsealk rapsealk self-requested a review August 13, 2024 09:25
Copy link
Member

@rapsealk rapsealk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the feature/support-gaudi-2 branch from bc59834 to 57f6743 Compare August 19, 2024 01:35
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from 76d119e to c7f9ca3 Compare August 19, 2024 01:35
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Aug 19, 2024
@agatha197 agatha197 changed the title feat: add intel icon feat: add gaudi2 icon Aug 19, 2024
@agatha197 agatha197 changed the title feat: add gaudi2 icon feat: add Gaudi 2 icon Aug 19, 2024
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from c7f9ca3 to d17a3cb Compare August 19, 2024 01:57
@agatha197 agatha197 force-pushed the feature/support-gaudi-2 branch from 57f6743 to b6be240 Compare August 19, 2024 02:54
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from d17a3cb to 5f9f516 Compare August 19, 2024 02:54
@github-actions github-actions bot added size:M 30~100 LoC and removed size:L 100~500 LoC labels Aug 19, 2024
@agatha197 agatha197 force-pushed the feature/support-gaudi-2 branch from b6be240 to adc48a4 Compare August 19, 2024 02:57
@agatha197 agatha197 force-pushed the feat/add-intel-icon branch from 5f9f516 to 3291342 Compare August 19, 2024 03:03
@agatha197 agatha197 merged commit 3291342 into feature/support-gaudi-2 Aug 19, 2024
3 of 4 checks passed
@agatha197 agatha197 deleted the feat/add-intel-icon branch August 19, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants