Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test code for getImageMeta #2663

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Aug 28, 2024

TL;DR

Added a new test case for handling exceptions in the getImageMeta function.
This is test code for #2109

What changed?

  • Imported the getImageFullName function from the helper module.
  • Added a new test case getImageMeta handle exception to the useBackendAIImageMetaData test suite.
  • The new test case verifies that getImageMeta correctly handles and processes complex image metadata.

How to test?

  1. Run the test suite for useBackendAIImageMetaData.
  2. Verify that the new test case passes successfully.
  3. Ensure that the getImageMeta function correctly extracts the key and tags from the provided image metadata.

Why make this change?

This change improves the test coverage for the getImageMeta function, specifically for handling complex image metadata scenarios. It ensures that the function can correctly process and extract relevant information from various image configurations, including those with multiple resource limits and labels.

Copy link
Member Author

yomybaby commented Aug 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yomybaby and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Aug 28, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:M 30~100 LoC label Aug 28, 2024
@yomybaby yomybaby marked this pull request as ready for review August 28, 2024 07:50
@yomybaby yomybaby force-pushed the chore/test-get-image-meta branch from ac092d6 to d16ce57 Compare August 28, 2024 07:53
@yomybaby yomybaby force-pushed the chore/test-get-image-meta branch from d16ce57 to d20179f Compare August 28, 2024 07:54
@yomybaby yomybaby changed the base branch from chore/pnpm-patch-react-project to main August 28, 2024 07:54
@yomybaby yomybaby merged commit 0bc1f90 into main Aug 28, 2024
4 checks passed
@yomybaby yomybaby deleted the chore/test-get-image-meta branch August 28, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant