fix: Change resource display basis from Ratio to current amount #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
ironAiken2
force-pushed
the
fix/modify-resources-_display-basis
branch
from
0299bfb to
89b8f56
Compare
ironAiken2
force-pushed
the
fix/modify-resources-_display-basis
branch
from
89b8f56 to
3773f0b
Compare
Merge activity
|
### TL;DR > After https://github.com/lablup/backend.ai-webui/pull/2640/files PR, With the use of ternary operators, the traditional string '/' has been marked as an arithmetic operation to represent Ratio. Updated session list display to show absolute memory usage instead of percentage. ### What changed? - Modified the memory usage display in the session list to show absolute values in GiB instead of percentages. - Removed the calculation that divided current memory usage by total capacity. - Adjusted the decimal precision for memory display from 2 to 1 for system memory and kept it at 2 for CUDA memory. - Added a console log statement to output row data for debugging purposes. ### How to test? 1. Navigate to the session list view. 2. Create or observe existing sessions in 'batch', 'interactive', 'inference', or 'running' states. 3. Verify that the memory usage is displayed as absolute values in GiB rather than percentages. 4. Check that system memory is displayed with one decimal place and CUDA memory with two decimal places. ### Why make this change? This change provides users with a clearer understanding of actual memory consumption in sessions. Displaying absolute values instead of percentages allows for more accurate resource monitoring and helps users make informed decisions about their session management. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
fix/modify-resources-_display-basis
branch
from
3773f0b to
7eab309
Compare
yomybaby
pushed a commit
that referenced
this pull request
Sep 4, 2024
### TL;DR > After https://github.com/lablup/backend.ai-webui/pull/2640/files PR, With the use of ternary operators, the traditional string '/' has been marked as an arithmetic operation to represent Ratio. Updated session list display to show absolute memory usage instead of percentage. ### What changed? - Modified the memory usage display in the session list to show absolute values in GiB instead of percentages. - Removed the calculation that divided current memory usage by total capacity. - Adjusted the decimal precision for memory display from 2 to 1 for system memory and kept it at 2 for CUDA memory. - Added a console log statement to output row data for debugging purposes. ### How to test? 1. Navigate to the session list view. 2. Create or observe existing sessions in 'batch', 'interactive', 'inference', or 'running' states. 3. Verify that the memory usage is displayed as absolute values in GiB rather than percentages. 4. Check that system memory is displayed with one decimal place and CUDA memory with two decimal places. ### Why make this change? This change provides users with a clearer understanding of actual memory consumption in sessions. Displaying absolute values instead of percentages allows for more accurate resource monitoring and helps users make informed decisions about their session management. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated session list display to show absolute memory usage instead of percentage.
What changed?
How to test?
Why make this change?
This change provides users with a clearer understanding of actual memory consumption in sessions. Displaying absolute values instead of percentages allows for more accurate resource monitoring and helps users make informed decisions about their session management.
Checklist: (if applicable)