fix: used slot calculation in resource broker when hideAgents is false #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
Merge activity
|
#2790) <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> ### This PR resolves cases where the remaining resource calculation is incorrect. [Teams](https://teams.microsoft.com/l/message/19:[email protected]/1730271662948?tenantId=13c6a44d-9b52-4b9e-aa34-0513ee7131f2&groupId=74ae2c4d-ec4d-4fdf-b2c2-f5041d1e8631&parentMessageId=1730271662948&teamName=devops&channelName=Frontend&createdTime=1730271662948) **Chages:** - If the hideAgents option in `config.toml` is set to false, the resource broker calculates the remaining resources based on the agents that are schedulable. This solves the problem of `remaining` instead of `occupied` entering the used slot data. **How to test:** - Verify that the value of resource monitor on the session page is the same as the response value on the network. **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
fix/occupied-slot-in-resource-broker
branch
from
7221b7f to
45397f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves cases where the remaining resource calculation is incorrect.
Teams
Chages:
config.tomlis set to false, the resource broker calculates the remaining resources based on the agents that are schedulable. This solves the problem ofremaininginstead ofoccupiedentering the used slot data.How to test:
Checklist: (if applicable)