Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display Gaudi 2 util in session list #2791

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Oct 30, 2024

image.png

Changes:

This PR adds support for displaying Gaudi 2 utilization in the session list. It introduces a new section that shows the Gaudi 2 utilization percentage and a progress bar, similar to existing resource utilization displays.

Details:

  • Adds a conditional rendering block for Gaudi 2 slot information
  • Displays Gaudi 2 utilization percentage
  • Includes a progress bar to visually represent Gaudi 2 utilization

Rationale:

This addition allows users to monitor Gaudi 2 resource usage directly in the session list, providing better visibility and management of Gaudi 2 accelerators.

Copy link

graphite-app bot commented Oct 30, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:S 10~30 LoC label Oct 30, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yomybaby and the rest of your teammates on Graphite Graphite

@yomybaby yomybaby marked this pull request as ready for review October 30, 2024 07:45
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Oct 30, 2024

Merge activity

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/7fd86dab-ce1f-46ac-8e9a-2976ac3b5e1f.png)

**Changes:**

This PR adds support for displaying Gaudi 2 utilization in the session list. It introduces a new section that shows the Gaudi 2 utilization percentage and a progress bar, similar to existing resource utilization displays.

**Details:**

- Adds a conditional rendering block for Gaudi 2 slot information
- Displays Gaudi 2 utilization percentage
- Includes a progress bar to visually represent Gaudi 2 utilization

**Rationale:**

This addition allows users to monitor Gaudi 2 resource usage directly in the session list, providing better visibility and management of Gaudi 2 accelerators.
@yomybaby yomybaby force-pushed the fix/gauid2-util-in-session-list branch from 2c1f99a to d92b388 Compare October 30, 2024 08:06
@graphite-app graphite-app bot merged commit d92b388 into main Oct 30, 2024
5 checks passed
@graphite-app graphite-app bot deleted the fix/gauid2-util-in-session-list branch October 30, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants