Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CREATING session status #2849

Merged

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 13, 2024

After lablup/backend.ai#3114, Added CREATING session status to represent container creation phase, and redefined PREPARING status to specifically indicate pre-container preparation phases.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version: 24.12.0
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Nov 13, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added area:lib Library and SDK related issue. size:M 30~100 LoC labels Nov 13, 2024
Copy link
Member Author

fregataa commented Nov 13, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fregataa fregataa changed the base branch from topic/11-13-feat_support_new_status_of_session_and_kernel to graphite-base/2849 November 14, 2024 06:45
@fregataa fregataa force-pushed the topic/11-13-feat_replace_preparing_status_to_creating branch from 035be30 to 14895b2 Compare November 14, 2024 06:47
@fregataa fregataa changed the base branch from graphite-base/2849 to main November 14, 2024 06:47
@fregataa fregataa force-pushed the topic/11-13-feat_replace_preparing_status_to_creating branch from 14895b2 to 53e7d6d Compare November 14, 2024 06:47
Copy link

github-actions bot commented Nov 14, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.04% 398/7898
🔴 Branches 4.38% 237/5406
🔴 Functions 3.02% 78/2581
🔴 Lines 4.95% 383/7730

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 9e2be95

@fregataa fregataa force-pushed the topic/11-13-feat_replace_preparing_status_to_creating branch from 53e7d6d to d9fa62e Compare November 16, 2024 05:19
@fregataa fregataa added this to the 24.12 milestone Nov 16, 2024
@fregataa fregataa marked this pull request as ready for review November 16, 2024 05:23
@fregataa fregataa force-pushed the topic/11-13-feat_replace_preparing_status_to_creating branch from d9fa62e to 1dc7143 Compare November 16, 2024 05:47
@fregataa fregataa marked this pull request as draft November 18, 2024 01:01
@fregataa fregataa changed the title feat: Replace PREPARING status to CREATING feat: Add CREATING session status Nov 18, 2024
@fregataa fregataa force-pushed the topic/11-13-feat_replace_preparing_status_to_creating branch from 1dc7143 to 21756b3 Compare November 18, 2024 03:56
@fregataa fregataa marked this pull request as ready for review November 18, 2024 04:01
@fregataa fregataa requested review from rapsealk and lizable November 18, 2024 04:02
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapsealk
Copy link
Member

@fregataa Please resolve the conflicts! Thanks in advnace 👍

Copy link

graphite-app bot commented Dec 23, 2024

Merge activity

After lablup/backend.ai#3114, Added `CREATING` session status to represent container creation phase, and redefined `PREPARING` status to specifically indicate pre-container preparation phases.

**Checklist:** (if applicable)

- [x] Mention to the original issue
- [ ] Documentation
- [x] Minium required manager version: 24.12.0
- [x] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@yomybaby yomybaby force-pushed the topic/11-13-feat_replace_preparing_status_to_creating branch from 9f88a1a to 9e2be95 Compare December 23, 2024 23:00
@graphite-app graphite-app bot merged commit 9e2be95 into main Dec 23, 2024
7 checks passed
@graphite-app graphite-app bot deleted the topic/11-13-feat_replace_preparing_status_to_creating branch December 23, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:lib Library and SDK related issue. size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants