-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CREATING
session status
#2849
feat: Add CREATING
session status
#2849
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ae8dcb4
to
7265dfb
Compare
035be30
to
14895b2
Compare
14895b2
to
53e7d6d
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.04% | 398/7898 |
🔴 | Branches | 4.38% | 237/5406 |
🔴 | Functions | 3.02% | 78/2581 |
🔴 | Lines | 4.95% | 383/7730 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 9e2be95
53e7d6d
to
d9fa62e
Compare
d9fa62e
to
1dc7143
Compare
CREATING
session status
1dc7143
to
21756b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fregataa Please resolve the conflicts! Thanks in advnace 👍 |
21756b3
to
9f88a1a
Compare
Merge activity
|
After lablup/backend.ai#3114, Added `CREATING` session status to represent container creation phase, and redefined `PREPARING` status to specifically indicate pre-container preparation phases. **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [x] Minium required manager version: 24.12.0 - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
9f88a1a
to
9e2be95
Compare
After lablup/backend.ai#3114, Added
CREATING
session status to represent container creation phase, and redefinedPREPARING
status to specifically indicate pre-container preparation phases.Checklist: (if applicable)