[FR-341] fix: Page Error on Accessing Agent Summary with a Regular User Account #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.98% (+0% 🔼) |
398/7993 |
| 🔴 | Branches | 4.31% | 237/5502 |
| 🔴 | Functions | 2.98% (+0% 🔼) |
78/2614 |
| 🔴 | Lines | 4.9% (+0% 🔼) |
383/7820 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from c24a033
Merge activity
|
…er Account (#3004) Refactors SFTP scaling group data fetching in agent summary list because original code is for only superadmin. To allow all users access to the agent summary page, a different API should be used. This PR moves the SFTP scaling group data fetching logic from the AgentSummaryList component to the useCurrentProject hook. Instead of making a direct API call within the component, it now uses the pre-fetched data from the project context, improving code organization and reducing redundant API calls. The change simplifies the AgentSummaryList component by removing the direct backend client dependency and API call logic, while maintaining the same filtering functionality for SFTP upload agents. **Checklist:** - [ ] Documentation - [ ] Test case(s) to demonstrate the difference of before/after - Verify that SFTP agents are still properly filtered from the agent summary list - Confirm that the SFTP scaling group data is correctly shared through the project context
yomybaby
force-pushed
the
fix/cannot-access-agent-summary-with-user
branch
from
902602e to
c24a033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors SFTP scaling group data fetching in agent summary list because original code is for only superadmin. To allow all users access to the agent summary page, a different API should be used.
This PR moves the SFTP scaling group data fetching logic from the AgentSummaryList component to the useCurrentProject hook. Instead of making a direct API call within the component, it now uses the pre-fetched data from the project context, improving code organization and reducing redundant API calls.
The change simplifies the AgentSummaryList component by removing the direct backend client dependency and API call logic, while maintaining the same filtering functionality for SFTP upload agents.
Checklist: