chores(FR-342): Add ESLint Configuration for JSON Schema Validation #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yomybaby
changed the title
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.97% | 398/8001 |
| 🔴 | Branches | 4.29% | 237/5522 |
| 🔴 | Functions | 2.98% | 78/2615 |
| 🔴 | Lines | 4.89% | 383/7828 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 0de11e4
yomybaby
force-pushed
the
chores/eslint-configuration-for-json-schema
branch
from
8ecfbb1 to
9d5fabe
Compare
agatha197
requested changes
Jan 10, 2025
Merge activity
|
…3008) resolves #3007 This pull request introduces changes to enhance ESLint configuration and add JSON schema validation for i18n files. The most important changes include updates to the `.eslintrc.json` file to support JSON files, additions to `package.json` for new dependencies, and modifications to `pnpm-lock.yaml` to reflect these updates. ### ESLint Configuration Enhancements: * [`.eslintrc.json`](diffhunk://#diff-6884918dc8291219be508e05e28965b958c734def85324f3b53858ea4702090fL21-R31): Added support for `json-schema-validator` plugin and `jsonc-eslint-parser` to handle JSON files. [[1]](diffhunk://#diff-6884918dc8291219be508e05e28965b958c734def85324f3b53858ea4702090fL21-R31) [[2]](diffhunk://#diff-6884918dc8291219be508e05e28965b958c734def85324f3b53858ea4702090fR62-R71) ### Dependency Additions: * [`package.json`](diffhunk://#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R145): Added `eslint-plugin-json-schema-validator` and `jsonc-eslint-parser` to dependencies. [[1]](diffhunk://#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R145) [[2]](diffhunk://#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R155) ### Lock File Updates: * [`pnpm-lock.yaml`](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR328-R330): Updated to include new dependencies and their versions, such as `eslint-plugin-json-schema-validator`, `jsonc-eslint-parser`, and related utilities. [[1]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR328-R330) [[2]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR358-R360) [[3]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR6773-R6778) [[4]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR6804-R6814) [[5]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR6867-R6872) [[6]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR8622-R8624) [[7]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR8656-R8659) [[8]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR9300-R9303) [[9]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR13025-R13028) [[10]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL18557-R18615) [[11]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR18666-R18669) [[12]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL18659-R18711) [[13]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR21121-R21125) [[14]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR21169-R21174) [[15]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR21233-R21251) [[16]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL21402-R21485) [[17]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR23721-R23724) [[18]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR23753-R23759) [[19]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR24590-R24593) [[20]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL27644-R27741) [[21]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL27655-R27752) [[22]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR27887-R27890) [[23]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL28053-R28154) [[24]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL28415-R28518) [[25]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbL28544-R28645) [[26]](diffhunk://#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR29112-R29117) ### JSON Schema for i18n Files: * [`resources/i18n.schema.json`](diffhunk://#diff-342e8679a2075e67940a1a5b6ba3739ab196d58725885360cb2ecd423f106e9bR1-R23): Added a new JSON schema to validate i18n files. * [`resources/i18n/de.json`](diffhunk://#diff-9e4def5f36ad2056d444a02f134fb777ad68017ca9e80cd87c8d594a2b3debe9R2): Linked the new JSON schema to the German i18n file. ### Linting Command Update: * [`react/package.json`](diffhunk://#diff-5a3f058f37c9436d08fa97bd30209f67c9a1a61d041b0ce27e48613dfb3a1a10L70-R70): Updated the `lint` script to include i18n JSON files.
agatha197
force-pushed
the
chores/eslint-configuration-for-json-schema
branch
from
5263053 to
0de11e4
Compare
graphite-app
bot
deleted the
chores/eslint-configuration-for-json-schema
branch
yomybaby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3007
This pull request introduces changes to enhance ESLint configuration and add JSON schema validation for i18n files. The most important changes include updates to the
.eslintrc.jsonfile to support JSON files, additions topackage.jsonfor new dependencies, and modifications topnpm-lock.yamlto reflect these updates.ESLint Configuration Enhancements:
.eslintrc.json: Added support forjson-schema-validatorplugin andjsonc-eslint-parserto handle JSON files. [1] [2]Dependency Additions:
package.json: Addedeslint-plugin-json-schema-validatorandjsonc-eslint-parserto dependencies. [1] [2]Lock File Updates:
pnpm-lock.yaml: Updated to include new dependencies and their versions, such aseslint-plugin-json-schema-validator,jsonc-eslint-parser, and related utilities. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26]JSON Schema for i18n Files:
resources/i18n.schema.json: Added a new JSON schema to validate i18n files.resources/i18n/de.json: Linked the new JSON schema to the German i18n file.Linting Command Update:
react/package.json: Updated thelintscript to include i18n JSON files.