Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR-344] feat: auto screenshot with Playwrite #3011

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jan 9, 2025

resolves https://lablup.atlassian.net/browse/FR-344

Added screenshot testing functionality to capture UI states across all routes. The tests take screenshots in four variations for each route:

  • Normal view
  • Dark mode
  • Without sidebar
  • Dark mode without sidebar

Added configuration option test.screenshotPath to specify custom screenshot save location, defaulting to e2e/screenshots directory.

Upgraded Playwright test framework from v1.46.1 to v1.49.1 for improved testing capabilities.

@github-actions github-actions bot added the size:M 30~100 LoC label Jan 9, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 force-pushed the feat/screenshot-all-page-with-test-file branch from 10c0b74 to 8a0ae61 Compare January 9, 2025 08:08
@agatha197 agatha197 marked this pull request as draft January 9, 2025 08:15
@agatha197 agatha197 force-pushed the feat/screenshot-all-page-with-test-file branch from 8a0ae61 to 65d19d4 Compare January 9, 2025 08:50
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Jan 9, 2025
@agatha197 agatha197 marked this pull request as ready for review January 9, 2025 08:54
@agatha197 agatha197 force-pushed the feat/screenshot-all-page-with-test-file branch 2 times, most recently from 9be3ac5 to 45339d5 Compare January 9, 2025 10:15
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I know there's a way to handle tests that take a long time to run, but I'll have to look into that.

e2e/test-util.ts Outdated Show resolved Hide resolved
@agatha197 agatha197 force-pushed the feat/screenshot-all-page-with-test-file branch from 22422e1 to e6be377 Compare January 10, 2025 10:07
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitignore Outdated Show resolved Hide resolved
Copy link

graphite-app bot commented Jan 10, 2025

Merge activity

resolves https://lablup.atlassian.net/browse/FR-344

Added screenshot testing functionality to capture UI states across all routes. The tests take screenshots in four variations for each route:
- Normal view
- Dark mode
- Without sidebar
- Dark mode without sidebar

Added configuration option `test.screenshotPath` to specify custom screenshot save location, defaulting to `e2e/screenshots` directory.

Upgraded Playwright test framework from v1.46.1 to v1.49.1 for improved testing capabilities.
@yomybaby yomybaby force-pushed the feat/screenshot-all-page-with-test-file branch from 930fce6 to 16581b9 Compare January 10, 2025 11:06
@graphite-app graphite-app bot merged commit 16581b9 into main Jan 10, 2025
5 checks passed
@graphite-app graphite-app bot deleted the feat/screenshot-all-page-with-test-file branch January 10, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants