Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-360): add max_pending_session_count, max_concurrent_sftp_sessions to keypair resource policy. #3025

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jan 14, 2025

resolves #3017
related PR: https://lablup.atlassian.net/browse/FR-317

Added support for two new resource policy fields in keypair resource policy:

  • max_pending_session_count: Controls maximum number of sessions that can be in pending state
  • max_concurrent_sftp_sessions: Controls maximum number of concurrent SFTP sessions

Checklist:

  • Minimum required manager version: v24.03.4
  • Test cases:
    • Create/modify keypair resource policy with new fields
    • Verify unlimited values work correctly (null for pending sessions, 0 for SFTP sessions)
    • Check fields are hidden when manager version < 24.03.4
    • Verify CSV export includes new fields
    • Test form validation and limits (0 to 2^31-1)

The PR also includes:

  • Improved form layout and styling in resource policy modal
  • Updated translations for new fields across all languages
  • Refactored unlimited value handling in FormItemWithUnlimited component

Screenshots:
image
image

@github-actions github-actions bot added area:lib Library and SDK related issue. area:ux UI / UX issue. area:i18n Localization labels Jan 14, 2025
@github-actions github-actions bot added the size:L 100~500 LoC label Jan 14, 2025
Copy link
Contributor Author

agatha197 commented Jan 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 14, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.95% (-0.01% 🔻)
398/8043
🔴 Branches
4.26% (-0.02% 🔻)
237/5565
🔴 Functions
2.96% (-0.01% 🔻)
78/2631
🔴 Lines
4.87% (-0.01% 🔻)
383/7869

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from b8ee0c8

@agatha197 agatha197 added this to the 24.12 milestone Jan 14, 2025
@agatha197 agatha197 force-pushed the feature/support-new-2403-fields-to-keypair-resource-policy branch 2 times, most recently from 73e6232 to 27be261 Compare January 14, 2025 07:19
@agatha197 agatha197 force-pushed the feature/support-new-2403-fields-to-keypair-resource-policy branch from 27be261 to b8ee0c8 Compare January 14, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's add max_pending_session_count, max_concurrent_sftp_sessions to keypair resource policy.
1 participant