Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-255): synchronize the file input in the LLM Playground. #3032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jan 15, 2025

resolves #2861 (FR-255)

Adds file attachment synchronization support to the LLM chat interface, enabling consistent file handling across multiple chat instances. When files are attached in one chat window, they are now properly synchronized across all active chat sessions.

Changes:

  • Introduces synchronizedAttachmentState atom for managing shared file attachments
  • Adds file attachment handling in EndpointLLMChatCard
  • Implements createDataTransferFiles utility function for consistent file processing
  • Updates attachment state management in LLMChatCard

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review:
    • Test file attachments in synchronized chat mode
    • Verify attachments persist across chat instances
  • Minimum requirements to check during review:
    • File attachments sync correctly between chat windows
    • Attachments clear properly after submission
    • Supported file types (image/, text/) work as expected
  • Test cases:
    1. Attach files in one chat window, verify sync in others
    2. Submit message with attachments, confirm proper clearing
    3. Test with various file types to ensure compatibility

Screenshots:
image.png]

@github-actions github-actions bot added the size:M 30~100 LoC label Jan 15, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.95% (-0.01% 🔻)
398/8046
🔴 Branches
4.26% (-0.01% 🔻)
237/5566
🔴 Functions
2.97% (-0% 🔻)
78/2630
🔴 Lines
4.87% (-0.01% 🔻)
383/7872

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from f0b7278

@agatha197 agatha197 requested review from lizable and yomybaby January 15, 2025 05:45
@agatha197 agatha197 added field:UI / UX impact:visible This change is visible to users. urgency:3 Must be finished within a certain time frame. type:enhance Add new features labels Jan 15, 2025 — with Graphite App
@yomybaby yomybaby requested a review from ironAiken2 January 15, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field:UI / UX impact:visible This change is visible to users. size:M 30~100 LoC type:enhance Add new features urgency:3 Must be finished within a certain time frame.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve LLM Playground UX
1 participant