feat(FR-372): support id based object resolution #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:lib
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.93% | 398/8072 |
| 🔴 | Branches | 4.27% | 239/5601 |
| 🔴 | Functions | 2.95% | 78/2640 |
| 🔴 | Lines | 4.85% | 383/7897 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 85cae43
Merge activity
|
agatha197
added
urgency:5
Graphite App
fregataa
reviewed
Jan 15, 2025
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
2463346 to
ce97896
Compare
ironAiken2
requested changes
Jan 15, 2025
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
ce97896 to
8cda7c0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
8cda7c0 to
433194e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
yomybaby
requested changes
Jan 16, 2025
yomybaby
requested changes
Jan 16, 2025
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
433194e to
19f49e7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
19f49e7 to
1eb8d27
Compare
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
2 times, most recently
from
d708bec to
ab1bf24
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
ab1bf24 to
be1b7af
Compare
This comment was marked as resolved.
This comment was marked as resolved.
yomybaby
requested changes
Jan 16, 2025
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
be1b7af to
13c06f7
Compare
ironAiken2
requested changes
Jan 16, 2025
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
13c06f7 to
83395f4
Compare
resolves #3039 (FR-372) related PR: lablup/backend.ai#3451 Adds support for vfolder ID-based operations in the backend client and updates related components to handle both name-based and ID-based folder operations. This change enables more reliable folder management by using unique IDs instead of potentially ambiguous folder names. **Changes:** - Introduces `vfolder-id-based` feature flag for manager versions 25.1.0, 24.09.5, and 24.03.11 - Updates folder operations (clone, rename, share, info) to use folder IDs when supported - Modifies file operations within folders to use the appropriate identifier - Updates UI components to handle both ID and name-based operations seamlessly **How to check:** 1. checkout core branch. refer: lablup/backend.ai#3451 2. check [BA-518](https://lablup.atlassian.net/browse/BA-518) in webui part. 3. modify manager compatible versions in esm file for testing **Checklist:** - [ ] Documentation - [x] Minimum required manager version: 24.03.12, 24.09.6, or 25.1.0 - [ ] Test case(s) to demonstrate the difference of before/after [BA-518]: https://lablup.atlassian.net/browse/BA-518?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
agatha197
force-pushed
the
feature/vfolder-id-based-operations
branch
from
83395f4 to
85cae43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3039 (FR-372)
related PR: lablup/backend.ai#3451
Adds support for vfolder ID-based operations in the backend client and updates related components to handle both name-based and ID-based folder operations. This change enables more reliable folder management by using unique IDs instead of potentially ambiguous folder names.
Changes:
vfolder-id-basedfeature flag for manager versions 25.1.0, 24.09.5, and 24.03.11How to check:
Checklist: