feat(FR-368): Update folder list Immediately after creating a new folder. #3053
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.92% (-0% 🔻) |
398/8094 |
| 🔴 | Branches | 4.25% | 239/5629 |
| 🔴 | Functions | 2.95% | 78/2641 |
| 🔴 | Lines | 4.84% (-0% 🔻) |
383/7919 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 918906c
ironAiken2
requested changes
Jan 22, 2025
agatha197
force-pushed
the
feat/update-immediately-after-creating-new-folder
branch
from
dba9631 to
918906c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3031 (FR-368)
Since the vfolder creation modal was migrated to a React component, the folder list does not update immediately after creation. We should trigger the new
backend-ai-folder-updatedevent if we only update the React modal.Adds a new event listener
backend-ai-folder-updatedto refresh the folder list when a folder is created or modified. This ensures the storage list view stays synchronized with folder changes.Checklist:
v24.09.0+post.0Check the folder list is updated immediately.