feature(FR-352): update-useBAINotification #3065
Merged
+136
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.92% (-0.01% 🔻) |
398/8093 |
| 🔴 | Branches | 4.25% (-0.01% 🔻) |
239/5629 |
| 🔴 | Functions | 2.95% (-0% 🔻) |
78/2641 |
| 🔴 | Lines | 4.84% (-0.01% 🔻) |
383/7918 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 644d9cc
yomybaby
requested changes
Jan 22, 2025
|
I couldn’t find a better way to handle typing. Although I did come across a method, the more I used it, the more confusing it became. So, I’ve decided to stick with my current approach. |
Merge activity
|
resolves #3060, [(FR-352)](https://lablup.atlassian.net/browse/FR-352) I added functionality to handle `task's status` based on the notification in `useNotification`. Since the existing approach was not changed, no additional modifications are needed. **changes** * update `useBAINotification` to handle task's status * refactor `MaintenanceSetttingList` component (I have confirmed that it is working properly.) **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feature/update-useBAINotification
branch
from
1ede928 to
644d9cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3060, (FR-352)
I added functionality to handle
task's statusbased on the notification inuseNotification. Since the existing approach was not changed, no additional modifications are needed.changes
useBAINotificationto handle task's statusMaintenanceSetttingListcomponent (I have confirmed that it is working properly.)Checklist: (if applicable)