Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FR-242): show vfolder list based on delegated user #3070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Jan 23, 2025

resolves #3017 (FR-242)

The ability to create a session by setting a Session Owner is not currently available. https://lablup.atlassian.net/browse/BA-414
In this PR, I'm aiming to show the right vfolder list for the set session owner.

In the VFolderTable used by the session launcher, we are fetching the vfolder list via the REST API. Since the API provides the ability to filter the data based on owner email, use it to show the vfolder list based on the delegated owner email assigned by the session launcher.

feature:

  • If owner is set in the session launcher, it will show a list of vfolders for that user.
  • If a previously selected vfolder exists, all selections will be reset when the owner related settings are changed.

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:S 10~30 LoC label Jan 23, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.9% (-0% 🔻)
398/8120
🔴 Branches
4.24% (-0.01% 🔻)
239/5641
🔴 Functions
2.95% (-0% 🔻)
78/2643
🔴 Lines
4.82% (-0% 🔻)
383/7945

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 315d315

@ironAiken2 ironAiken2 changed the title fix: show vfolder list based on delegated user fix(FR-242): show vfolder list based on delegated user Jan 23, 2025
@ironAiken2 ironAiken2 marked this pull request as ready for review January 23, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's add max_pending_session_count, max_concurrent_sftp_sessions to keypair resource policy.
1 participant