Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Upgrade halfstack (postgresql, redis, etcd) #1689

Closed
wants to merge 2 commits into from
Closed

deps: Upgrade halfstack (postgresql, redis, etcd) #1689

wants to merge 2 commits into from

Conversation

inureyes
Copy link
Member

@inureyes inureyes commented Nov 6, 2023

postgresql: 15.2 -> 16.0
redis: 7.0.5 -> 7.2.3
etcd: 3.5.6 -> 3.5.10

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Documentation
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to demonstrate the difference of before/after

@inureyes
update: postgresql, redis, etcd update
859828e 
 postgresql: 15.2  -> 16.0
 redis:      7.0.5 -> 7.2.3
 etcd:       3.5.6 -> 3.5.10
@github-actions github-actions bot added the size:M 30~100 LoC label Nov 6, 2023
@inureyes inureyes added type:maintenance Maintenance issue. comp:manager Related to Manager component area:upstream Issues with root cause from upstream 3rd parties effort:normal Need to understand a few modules / some extent of contextual or historical information. impact:invisible This change is invisible to users (internal changes). platform:general General platform issues. Most issues are general. urgency:3 Must be finished within a certain time frame. labels Nov 6, 2023
@inureyes inureyes added this to the 23.09 milestone Nov 6, 2023
@inureyes inureyes requested a review from achimnol November 6, 2023 00:59
achimnol
achimnol requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@achimnol achimnol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis and etcd are fine as they are minor upgrades.
But for postgres, this will BREAK existing dev setups!
For that part, #927 must be done first, which I'm considering including it as a part of the new community installer's extension. Before it, we should only upgrade the minor version of postgres.

@achimnol achimnol changed the title update: postgresql, redis, etcd update deps: Upgrade halfstack (postgresql, redis, etcd) Nov 7, 2023
@achimnol
Copy link
Member

I'm closing this. Please revisit this with a proper upgrade path for the postgres, at least as an explicit documentation.

@achimnol achimnol closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol requested changes

Assignees

@inureyes inureyes

Labels
area:upstream Issues with root cause from upstream 3rd parties comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. impact:invisible This change is invisible to users (internal changes). platform:general General platform issues. Most issues are general. size:M 30~100 LoC type:maintenance Maintenance issue. urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
2 participants
@inureyes @achimnol