feat: Add frontend-endpoint and hide-side-menu-button to webserver's pipeline configs
#1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:webserver
.feature.md -> 1692.feature.md
agatha197
requested changes
Nov 7, 2023
There was a problem hiding this comment.
In lablup/backend.ai-webui#1929, the fasttrack's endpoint is saved named endpoint not fasttrack-endpoint. If you want to rename this, it needs a new PR to handle that in webui.
agatha197
reviewed
Nov 7, 2023
yomybaby
reviewed
Nov 8, 2023
rapsealk
changed the title
frontend-endpoint and hide-button to webserver's pipeline configsfrontend-endpoint and hide-side-menu-button to webserver's pipeline configs
|
After this PR merged, let's make a WebUI PR to use these options. |
kyujin-cho
approved these changes
Nov 8, 2023
6 tasks
5 tasks
kyujin-cho
pushed a commit
that referenced
this pull request
Nov 27, 2023
…r's pipeline configs (#1692) Backported-from: main Backported-to: 23.09
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #1576
This PR adds additional configs
frontend-endpointandhide-buttonto webserver's pipeline configs.pipeline.frontend-endpointwill be used for "FastTrack" shortcut button on WebUI. Currently, the button is usingpipeline.endpoint, which references the pipeline service's API server. The value has to be the pipeline service's frontend app as the button is intended to be a shortcut for the pipeline service.hide-buttonwill provide an option to hide the "FastTrack" button or not.Checklist: (if applicable)