Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow Undefined value to ModifyGroupInput.user_update_mode #1698

Merged
merged 3 commits into from
Nov 7, 2023
Merged

fix: allow Undefined value to ModifyGroupInput.user_update_mode #1698

merged 3 commits into from
Nov 7, 2023

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 7, 2023 •
edited
Loading

follow-up #1688
partial fix of #1697

ModifyGroupInput.user_update_mode field can have Undefined value since #1688, let's allow the value.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added the urgency:5 It is imperative that action be taken right away. label Nov 7, 2023
@fregataa fregataa added this to the 24.03 milestone Nov 7, 2023
@fregataa fregataa self-assigned this Nov 7, 2023
@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Nov 7, 2023
@fregataa fregataa modified the milestones: 24.03, 23.09 Nov 7, 2023
agatha197
agatha197 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the quick response.

@fregataa fregataa added this pull request to the merge queue Nov 7, 2023
@fregataa fregataa removed this pull request from the merge queue due to a manual request Nov 7, 2023
@fregataa fregataa changed the title fix: allow any value of user_update_mode fix: allow Undefined value to ModifyGroupInput.user_update_mode Nov 7, 2023
@fregataa fregataa added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit b31efcb Nov 7, 2023
20 checks passed
@fregataa fregataa deleted the hotfix/allow-any-user-update-mode branch November 7, 2023 06:32
fregataa added a commit that referenced this pull request Nov 7, 2023
@fregataa
fix: allow Undefined value to ModifyGroupInput.user_update_mode (#…
a59adf7 
…1698)

Backported-from: main
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@achimnol achimnol Awaiting requested review from achimnol

Assignees

@fregataa fregataa

Labels
comp:manager Related to Manager component size:XS ~10 LoC urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
2 participants
@fregataa @agatha197