Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(BA-502): Add the skeleton interface of vfolder CRUD handlers in storage-proxy (#3434) #3516

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MintCat98
Copy link

resolves #3434 (BA-502)

Add skeletion interface of storage-proxy handlers for refactoring.

Files were added in ./src/ai/backend/storage/api/vfolder

init.py
manager_handler.py
manager_service.py
types.py

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added comp:storage-proxy Related to Storage proxy component size:XL 500~ LoC labels Jan 22, 2025
@HyeockJinKim
Copy link
Collaborator

Please check the reason for the CI failure as well.

@MintCat98
Copy link
Author

Please check the reason for the CI failure as well.

I made some changes before committing, but I found that I only ran pants check :: and forgot to run pants test. I'll fix the test errors along with other modifications and ping you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:storage-proxy Related to Storage proxy component size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the skeleton interface of VFolder CRUD APIs using the new layered architecture in storage-proxy
2 participants