Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor as custom package #43

Merged
merged 3 commits into from
May 23, 2022
Merged

Refactor as custom package #43

merged 3 commits into from
May 23, 2022

Conversation

cboulay
Copy link
Collaborator

@cboulay cboulay commented Mar 15, 2022

This refactors LSL4Unity as a Unity Custom Package that can be installed using the Editor's integrated package manager.

Once the package is installed, it is also possible to install "Samples". Here we provide 3 samples. The first 2 are simple examples of an inlet and an outlet using only LSL.cs. The third is a slightly more complicated yet robust (functionally) example that leverages the Utilities provided in the LSL4Unity namespace.

Here are some issues encountered (and solved):

  • Objects in Samples are missing scripts. The solution is to completely replace existing Samples with new ones.
  • There are some namespace clashes. StreamInfo was one, but I patched this.
  • We have both Resolver and LSLResolver. They are almost identical. These need to be merged.
  • Any event streams need to have their default types set to Markers so they can be auto-imported in EEGLAB (to make it easier for users)
  • Build testing -- Does it pull in the lsl.dll? (I deleted the BuildHooks, might need to bring those back)
  • Check resolver on streams from other computers (see ContinuousResolver Issue #30)

@cboulay cboulay self-assigned this Mar 15, 2022
@cboulay
Copy link
Collaborator Author

cboulay commented Mar 23, 2022

Everything is working well in the editor. I need to test the builds. If anyone is interested in helping test (especially on Android) then please jump in.

@cboulay cboulay marked this pull request as ready for review May 23, 2022 20:23
@cboulay cboulay merged commit f247277 into master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant