Compatibility with more recent versions of Ogre #1538
+1,026
−547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolalaro
commented
Jan 8, 2025
rolalaro
commented
- Fix compatibilities issues with Ogre 1.12.10, 13.1.0 and 14.0.0
- Created 2 CIs to check the compilation of ViSP when Ogre is used as 3rd party. Unit tests for Ogre cannot be run because Ogre requires a valid X11 context
…d" and "Ogre::WindowEventListener : expected class-name before '{' token"
Moved detection of the visp-images outside the vp_add_test method, to make the detection possible even when tests are disabled
…cause it seemed to cause a problem when running successive configure steps
added 13 commits
January 6, 2025 10:41
…oying uninitialized vpAROgre
added 3 commits
January 10, 2025 08:06
The window did not close when clicking on the [x] button of the window. Now it works
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
=======================================
Coverage 54.01% 54.01%
=======================================
Files 441 441
Lines 53863 53865 +2
=======================================
+ Hits 29093 29095 +2
Misses 24770 24770 ☔ View full report in Codecov by Sentry. |
- Introduce vpDisplayFactory - Remove useless try/catch and other code
|
@rolalaro There remains a segfault when I run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.