docs(README): improve configuration files documentation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to edit each crate's toml file when bumping the version.
* refactor: move config extration into load_config * feat(node): load config separate per component This will let us specialize NodeConfig as currently it is supporting multiple things. * feat(node): normalize NodeConfig Remove redundant properties from the config options. This prevents user issues as only a single source of truth is allowed. * fix: configs ignore unknown properties Ignoring unknown configuration fields can lead to confusion as the user has no indication that it was ignored. Unknown properties now result in an error. * chore(node): update miden-node.toml config file * chore: update changelog
Use `Option<NonZeroU32>` instead of relying on zero to indicate none.
This removes the need to separately bundle this resource, simplifying the deployment process. The server url is now determined using the webpage url instead of being hardcoded to localhost. This means we no longer have to manually edit it to whatever IP it is being served on.
* tests: refactor, add tests for transaction batch * refactor: move mock methods to `test_utils` * tests: implement tests for batch/block producers and in-flight notes verifications * fix: clippy warnings * tests: fix getting unauthenticated input notes in `MockStoreSuccess` * tests: cache mocked private accounts in order to reuse them on next creations * tests: don't use 0's account index * tests: fix block builder test * format: apply rustfmt after merging * fix: clippy warnings * refactor: address review comments * refactor: accept suggestion from the review Co-authored-by: Mirko von Leipzig <[email protected]> * tests: address review comments --------- Co-authored-by: Mirko von Leipzig <[email protected]>
SantiagoPittella
force-pushed
the
fix-documentation-in-readme
branch
2 times, most recently
from
0ba3435 to
b0a4839
Compare
SantiagoPittella
force-pushed
the
fix-documentation-in-readme
branch
from
b0a4839 to
10f0330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.