Fix CI failing and update it with newer Ruby versions #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions 1.x of `mocha` where raising the following error when loading the code to run the tests: ``` /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/mocha-1.16.1/lib/mocha/integration/mini_test/adapter.rb:26:in `included': uninitialized constant MiniTest (NameError) Did you mean? Minitest from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/mocha-1.16.1/lib/mocha/integration/mini_test.rb:50:in `include' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/mocha-1.16.1/lib/mocha/integration/mini_test.rb:50:in `activate' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/mocha-1.16.1/lib/mocha/integration.rb:7:in `map' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/mocha-1.16.1/lib/mocha/integration.rb:7:in `activate' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/mocha-1.16.1/lib/mocha/setup.rb:10:in `activate' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/mocha-1.16.1/lib/mocha/setup.rb:14:in `<top (required)>' from /home/runner/work/resque-retry/resque-retry/test/test_helper.rb:20:in `require' from /home/runner/work/resque-retry/resque-retry/test/test_helper.rb:20:in `<top (required)>' from /home/runner/work/resque-retry/resque-retry/test/exponential_backoff_test.rb:1:in `require' from /home/runner/work/resque-retry/resque-retry/test/exponential_backoff_test.rb:1:in `<top (required)>' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:15:in `require' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:15:in `block in <main>' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:4:in `select' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:4:in `<main>' ``` The issue is that such versions of `mocha` are incompatible with `minitest` v5.19+ – see the related issue freerange/mocha#614.
The tests where failing with the following error: ``` /home/runner/work/resque-retry/resque-retry/test/server_test.rb:7:in `<top (required)>': uninitialized constant MiniTest (NameError) Did you mean? Minitest from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:15:in `require' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:15:in `block in <main>' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:4:in `select' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:4:in `<main>' ``` The issue is that the gem is still using `MiniTest` constant which is deprecated. This commit fixes this by using `Minitest` constant instead.
Versions 10.x of Rake where raising errors in using Ruby 3.2 and 3.3 when loading the code to run the tests: ``` NoMethodError: undefined method `=~' for #<Proc:0x00007f0fc5aee530 /opt/hostedtoolcache/Ruby/3.2.6/x64/lib/ruby/gems/3.2.0/gems/rake-10.5.0/lib/rake/application.rb:393 (lambda)> /opt/hostedtoolcache/Ruby/3.2.6/x64/bin/bundle:25:in `load' /opt/hostedtoolcache/Ruby/3.2.6/x64/bin/bundle:25:in `<main>' (See full trace by running task with --trace) ```
|
Looks good. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI that is currently failing and adds Ruby 3.2 and 3.3 to the CI matrix.