fix: Don't set newLineWritten to true unless verbosity allows output (#…

…54127)
laravel · Jan 9, 2025 · 6291298 · 6291298
1 parent 36a4a53
commit 6291298
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/Illuminate/Console/OutputStyle.php b/src/Illuminate/Console/OutputStyle.php
@@ -80,8 +80,10 @@ public function write(string|iterable $messages, bool $newline = false, int $opt
     #[\Override]
     public function writeln(string|iterable $messages, int $type = self::OUTPUT_NORMAL): void
     {
-        $this->newLinesWritten = $this->trailingNewLineCount($messages) + 1;
-        $this->newLineWritten = true;
+        if ($this->output->getVerbosity() >= $type) {
+            $this->newLinesWritten = $this->trailingNewLineCount($messages) + 1;
+            $this->newLineWritten = true;
+        }
 
         parent::writeln($messages, $type);
     }

diff --git a/tests/Console/OutputStyleTest.php b/tests/Console/OutputStyleTest.php
@@ -54,4 +54,21 @@ public function testDetectsNewLineOnWriteln()
         $style->writeln('Foo');
         $this->assertTrue($style->newLineWritten());
     }
+
+    public function testDetectsNewLineOnlyOnOutput()
+    {
+        $bufferedOutput = new BufferedOutput();
+
+        $style = new OutputStyle(new ArrayInput([]), $bufferedOutput);
+
+        $style->setVerbosity(OutputStyle::VERBOSITY_NORMAL);
+
+        $style->writeln('Foo', OutputStyle::VERBOSITY_VERBOSE);
+        $this->assertFalse($style->newLineWritten());
+
+        $style->setVerbosity(OutputStyle::VERBOSITY_VERBOSE);
+
+        $style->writeln('Foo', OutputStyle::VERBOSITY_VERBOSE);
+        $this->assertTrue($style->newLineWritten());
+    }
 }