Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x]: Fixed method parameter formatting #52860

Closed

Conversation

flavio-schoute
Copy link
Contributor

I was just looking around in the code and suddenly I saw a totally different structure with define parameters. I thought we should make that consistent with the rest of the code base.

@crynobone
Copy link
Member

Hi there,

This is a common usage set by @taylorotwell and we normally don't change it unless StyleCI warrants it.

@flavio-schoute
Copy link
Contributor Author

That could/might be true I have no idea but the checks all pass. It is strange because this is the only method where it is done this way and the rest of the methods are actually all the same.

@taylorotwell
Copy link
Member

I think it's OK.

@flavio-schoute flavio-schoute deleted the fix/method-parameters branch September 20, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants