[11.x] Fix handling exceptions thrown in eval()'d code #53204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlabedo
force-pushed
the
fix-handling-errors-from-eval-code
branch
from
3d8bf20 to
303e542
Compare
jlabedo
force-pushed
the
fix-handling-errors-from-eval-code
branch
from
303e542 to
d49d901
Compare
|
What is the behavior after this fix? |
|
Hello @taylorotwell, here is the error screen after this fix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix issue #53203
Before
If an exception is thrown from an eval()'d code, the error handler throws and shows a strange error screen, hiding the real one:
After
After this fix it shows:
