Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fixes handling Js::from(collect()); #53206

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[11.x] Fixes handling Js::from(collect()); #53206

merged 1 commit into from
Oct 18, 2024

Conversation

crynobone
Copy link
Member

  • Reduce enum_value() usage on Illuminate\Support\Js to only when $data is instance of UnitEnum.
  • enum_value() should always return $value unless $default is set other than null.

fixes #53205

@crynobone crynobone marked this pull request as ready for review October 17, 2024 23:08
@taylorotwell taylorotwell merged commit f7e2fab into 11.x Oct 18, 2024
34 checks passed
@taylorotwell taylorotwell deleted the fixes-53205 branch October 18, 2024 01:51
@wizzymore wizzymore mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Js::from() returns null when passed an empty collection
2 participants
@crynobone @taylorotwell