[11.x] feat: Create missing pgsql database when running migrations #54314
+48
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasgrimm
commented
Jan 23, 2025
| || ( | ||
| ($e->getPrevious()->errorInfo[0] ?? null) == '08006' | ||
| && $connection->getDriverName() == 'pgsql' | ||
| && Str::contains($e->getPrevious()->getMessage(), '"'.$connection->getDatabaseName().'"') |
There was a problem hiding this comment.
Pgsql has no specific code for missing database. https://www.postgresql.org/docs/current/errcodes-appendix.html
If we don't check for a string such as the database name which is part of the error, a wrong username or password would also offer the user the option to create a database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the MySQL counterpart to #44153
Create missing pgsql database like we do for MySQL(and SQLite) when running migrations
When creating a fresh Laravel install, it will fail
