#161 supports empty items arr (#187)

lawnstarter · Jun 11, 2019 · 3a6730d · 3a6730d
1 parent fbe828b
commit 3a6730d
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,11 @@
+### 6.2.0
+
+##### New
+
+-   Supports an empty `items` array (#161)
+
+---
+
 ### 6.1.1
 
 ##### Bugfix

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "react-native-picker-select",
-    "version": "6.1.1",
+    "version": "6.2.0",
     "description": "A Picker component for React Native which emulates the native <select> interfaces for each platform",
     "license": "MIT",
     "author": "Michael Lefkowitz <[email protected]>",

diff --git a/src/index.js b/src/index.js
@@ -106,7 +106,7 @@ export default class RNPickerSelect extends PureComponent {
             idx = 0;
         }
         return {
-            selectedItem: items[idx],
+            selectedItem: items[idx] || {},
             idx,
         };
     }

diff --git a/test/test.js b/test/test.js
@@ -107,6 +107,14 @@ describe('RNPickerSelect', () => {
         expect(done_bar).toHaveLength(0);
     });
 
+    it('should handle an empty items array', () => {
+        const wrapper = shallow(
+            <RNPickerSelect items={[]} placeholder={{}} onValueChange={() => {}} />
+        );
+
+        expect(wrapper.state().items).toHaveLength(0);
+    });
+
     it('should return the expected option to a callback passed into onSelect', () => {
         const onValueChangeSpy = jest.fn();
         const wrapper = shallow(