-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue with the picker not opening on ios with the new architecture #542
base: master
Are you sure you want to change the base?
fix: issue with the picker not opening on ios with the new architecture #542
Conversation
does this have any regressions on the previous architecture? |
When I do this I can click on the picker, but the modal that opens goes to the top of the screen and is not visible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can we merge this ASAP?
Agreed, this fixes the breaking change with Expo SDK 52. |
This fix should be enough to fix this problem. And after doing a regression, I didn't notice any new problems arise. |
no new problems <<<< breaking changes IMPO (in my personal opinion) this needs to be expedited sooner than later |
@exlymex can you fix the conflicts? |
Please, can this PR be merged? This can help resolve this particular issue. Please fix the conflict @exlymex |
In the meantime you can now pass the props to the Picker: |
On the new architecture the TextInput used to display the text was intercepting events. This seems to be caused by the view-flattening algorithm moving it out of the parent view which has pointerEvents="box-only" set.
The solution would be either to add pointerEvents="none" to the TextInput itself, as done in this PR, or to disable the view flattening for the parent view (by adding collapsable={false} prop to it), so the native view structure would match the react one.