Allow horizontal scrolling adpated from @santi6291 #53
Conversation
|
Oh great. I want this badly 👍 |
|
@zhonghuiwen can you rebase and fix the indentation issues? |
inobounce.js
Outdated
| @@ -1,9 +1,11 @@ | |||
| /* eslint-disable */ // REMOVEEEEE | |||
inobounce.js
Outdated
| @@ -38,25 +40,20 @@ | |||
| } | |||
|
|
|||
| var scrolling = style.getPropertyValue('-webkit-overflow-scrolling'); | |||
| var overflowY = style.getPropertyValue('overflow-y'); | |||
| var overflowY = style.getPropertyValue('overflow-y'); | |||
| var overflowX = style.getPropertyValue('overflow-x'); | |||
There was a problem hiding this comment.
Indentation seems to be wrong here and in other places.
inobounce.js
Outdated
| evt.preventDefault(); | ||
| if (overflowY === 'auto' || overflowY === 'scroll') { | ||
| horScroll(evt, height, el) | ||
| } else { |
|
This is looking pretty good. If we can fix up the coding style and validate it's working on the latest iOS, I think we can merge. |
|
@zhonghuiwen can you comment on the code changes in #44 ? Let's get that into this PR as well if it's necessary. |
|
@lazd Thanks for the review! fixed the coding style |
|
@zhonghuiwen sorry about being so slow to merge this. Has this been tested on the latest iOS? |
|
I can verify the fix works on iOS 12.1 |
|
@saylynt excellent. Can you share the HTML/CSS code you tested iNoBounce on? Was it an included example? |
|
I'd been trying to prevent scrolling for hours and have tried about a dozen solutions that failed when horizontal scrolling was involved. Just installed this PR and it solved my problem beautifully. Hoping for approval! I'm a pretty inexperienced developer but here's how I'm using this. https://github.com/calebmisclevitz/hours |
Fixed horizontal scrolling for ios 11.3+, adapted from:
https://github.com/santi6291/iNoBounce