Templates • CHW plant #3167
Draft
Templates • CHW plant #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for DS#SR00937490-01
Dymola pedantic check fails but Dymola can otherwise proceed.
Dymola cannot translate Base any more, even w/o pedantic check
- This allows using parameters in binding equations, such as the number of units.
- Validation model runs w/ modulating CW isolation valves only
AntoineGautier
force-pushed
the
issue1374_template_CHW_final
branch
from
f495ab8 to
68d8084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall NOT be merged before #2299 is merged.
This is a draft PR to test CI testing with
test-templates-optimicaandtest-templates-dymola.TODO before merging:
issue2293_chiller_plant_seqis merged into the master, replaceBuildings.Templates.ChilledWaterPlants.Components.Controls.Controller_debugwith the actual controller.Buildings/Resources/Scripts/travis/templates/ChilledWaterPlants.pyand.travis.yml.issue1374_template_CHW_finaluses port placement parameterization for the WSE and CT components.Note that the template models are currently not supported by Dymola due to a bug in handling arrays of record.
Tickets #SR01004314-01 #SR01022035-01 and #SR00955379-01 are in status "Wait for Correction Delivery" or "R&D Handling" at DS.
issue1374_template_CHW_finalis not kept in sync with the master since early 2023 due to the issue described below.