Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue4003 heat pump water heaters #4013

Draft
wants to merge 35 commits into
base: issue4003_HeatPumpWaterHeaters
Choose a base branch
from
Draft

Issue4003 heat pump water heaters #4013

wants to merge 35 commits into from

Conversation

karthikeyad-pnnl
Copy link
Contributor

No description provided.

terrancelu92 and others added 30 commits November 15, 2023 09:40
@terrancelu92
First rough implementation of the HPWH
7b503da
@terrancelu92
Parameterize the model
d7eb538
@terrancelu92
Add an example to the wrapped configuration model
9f10274
@terrancelu92
Add sensor location, and condenser location as model inputs
d04cded
@terrancelu92
Add validation cases
6553823
@terrancelu92
Change model based on EnergyPlus source code (1) Add heating fraction…
b0c98fd 
… (2) Weighted average condenser water temperature
@terrancelu92
Add documentation to heat pump water heater wrapped models
4ae4fcc
@terrancelu92
Add baseclass model for two configurations
e3c7379
@terrancelu92
Change example model setup
8e58730
@terrancelu92
Add curve fitting data and script
f309ce8
@terrancelu92
Merge branch 'master' into HeatPumpWaterHeater_Pumped
b2978e5
@terrancelu92
First implementation of pumped configuration HPWH
705d785
@terrancelu92
Implement a validation case for pumped HPWH
a7d92d5
@terrancelu92
Add debugging code
6b2db3d
@terrancelu92
Finalize the validation case
547a72d
@terrancelu92
Add all the documentation
cdbce2b
@terrancelu92
Remove unnecessary debugging files
a77dd18
@terrancelu92
Reduce the tank node from 12 to 5; Reduce the time period of validati…
fe05471 
…on cases
@cerrinamouchref-pnnl
Updated formating
2c4090c
@cerrinamouchref-pnnl
Revisions update
36a9cf5
@karthikeyad-pnnl
Merge pull request #152 from cerrinamouchref-pnnl/issue4003_HeatPumpW…
945cccc 
…aterHeaters

Issue4003 heat pump water heaters
@karthikeyad-pnnl
Restructured heat pump water heater package, including data records
2363b33
@karthikeyad-pnnl
Deleted examples package
ebd00d0
@karthikeyad-pnnl
Merge pull request #153 from terrancelu92/HeatPumpWaterHeater
4a8aed0 
Reduce the tank node from 12 to 5; Reduce the time period of validati…
@karthikeyad-pnnl
Merge branch 'issue4003_HeatPumpWaterHeaters_forPR' into issue4003_He…
b6ec4ff 
…atPumpWaterHeaters_mergeConflictFix
@karthikeyad-pnnl
Restored files with unnecessary changes
1e4870b
@karthikeyad-pnnl
Reverted additional files with unnecessary changes in Resources folder
f8d8a82
@karthikeyad-pnnl
Removed unused Dymola scripts
07d4032
@karthikeyad-pnnl
Rectified indexing issues in Dymola scripts
e6b5ac1
@karthikeyad-pnnl
Updated models to meet Buildings library conventions
739a702
@karthikeyad-pnnl
Merge pull request #155 from karthikeyad-pnnl/issue4003_HeatPumpWater…
b6bacad 
…Heaters_forPR

Issue4003 heat pump water heaters for pr
@karthikeyad-pnnl
Merge pull request #156 from lbl-srg/master
fe666e8 
Merging latest master
@karthikeyad-pnnl karthikeyad-pnnl marked this pull request as draft September 30, 2024 16:31
@karthikeyad-pnnl
Copy link
Contributor Author

@mwetter This PR is to merge the deliverables for the heat pump water heater. Please create a corresponding development branch on the repo so that I can rebase this PR on to that. Thanks!

@JayHuLBL JayHuLBL changed the base branch from master to issue4003_HeatPumpWaterHeaters November 22, 2024 19:31
@JayHuLBL
Copy link
Contributor

@karthikeyad-pnnl Please the errors below:

jianjunhu@ubuntu:~/GitFolder/karthikeyad-pnnl/modelica-buildings/Buildings$ ../bin/runUnitTests.py --validate-html-only
The following malformed html syntax has been found:
[-- ./Fluid/Storage/HeatPumpWaterHeater/PumpedCondenser.mo ]
line 67 column 5 - Warning: inserting implicit <p>
line 67 column 5 - Warning: trimming empty <p>

[-- ./Fluid/Storage/HeatPumpWaterHeater/WrappedCondenser.mo ]
line 59 column 5 - Warning: inserting implicit <p>
line 59 column 5 - Warning: trimming empty <p>

jianjunhu@ubuntu:~/GitFolder/karthikeyad-pnnl/modelica-buildings/Buildings$ ../bin/verifyFiles.py 
*** Error:  File 'Fluid/Storage/HeatPumpWaterHeater/BaseClasses/PartialHeater.mo' contains invalid string 'Algorithm='.
*** Error:  File 'Fluid/Storage/HeatPumpWaterHeater/BaseClasses/PartialHeater.mo' contains invalid string '__Dymola_Algorithm'.
*** Error:  File 'Fluid/Storage/HeatPumpWaterHeater/Validation/PumpedCondenser.mo' contains invalid string 'Algorithm='.
*** Error:  File 'Fluid/Storage/HeatPumpWaterHeater/Validation/PumpedCondenser.mo' contains invalid string '__Dymola_Algorithm'.
*** Error:  File 'Fluid/Storage/HeatPumpWaterHeater/Validation/PumpedCondenser.mo' contains invalid string regular expression 'file\s*=\s*"Resources' in 'file=
          "Resources'.
*** Error:  File 'Fluid/Storage/HeatPumpWaterHeater/Validation/WrappedCondenser.mo' contains invalid string 'Algorithm='.
*** Error:  File 'Fluid/Storage/HeatPumpWaterHeater/Validation/WrappedCondenser.mo' contains invalid string '__Dymola_Algorithm'.
*** Error:  File 'Fluid/Storage/HeatPumpWaterHeater/Validation/WrappedCondenser.mo' contains invalid string regular expression 'file\s*=\s*"Resources' in 'file=
          "Resources'.
*** Terminating due to found errors in examined files.

@JayHuLBL
Copy link
Contributor

@karthikeyad-pnnl Would you please work on the errors and check if there is any other fix needs to be done?

@JayHuLBL
Copy link
Contributor

JayHuLBL commented Jan 9, 2025

@karthikeyad-pnnl Do we have any change on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Spawn
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karthikeyad-pnnl @JayHuLBL @terrancelu92 @cerrinamouchref-pnnl @lzwang26