KCard: Remove the border-radius on align left #741
Assignees
Labels
Component: KCard
good first issue
Self-contained, straightforward, low-complexity
help wanted
Open source contributors welcome
P2 - normal
Priority: Nice to have
Milestone
Comments
AllanOXDi
added
the
good first issue
|
Hey!! I would like to work on this issue @AllanOXDi please assign me this issue!! |
|
Hi @Spoorthy1423 I have assigned it to you |
This was referenced Aug 23, 2024
|
Hey!! @AllanOXDi can u review my pr please!!! i would like to contribute to this repo further. |
|
Hey @Spoorthy1423 Thanks for letting me know . I have reviewed your PR and left for you a small comments. But overall, the changes looks good to me. Thank you for working on this issue. |
This was referenced Aug 26, 2024
|
Hey!! @MisRob i have raised another pr where i changed all the changes described and maintained changelog but in the last my pull request link is a bit wrong hope u get that in it..hope u like it Thank you!! |
This was referenced Aug 26, 2024
Closed
|
Close by #754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Summary
We need to remove border-radius when the thumbnail display is align left using
thumbnailAlignprop. But keep it when the the thumbnail is align left andthumbnailDisplayprop is smallReferences
This need is motivated by new additions to the cards family in Kolibri, such as
learningequality/kolibri#12318
learningequality/kolibri#12317
learningequality/kolibri#12319
Current behavior
When the card is align left we are still seeing small rounded corners around the card's outer border.
Expected behavior
The border-radius needs to be removed on
:thumbnailAlign='left' and:thumbnailDisplay='large'Acceptance criteria
The text was updated successfully, but these errors were encountered: