Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 741 resolved #756

Closed

Conversation

Spoorthy1423
Copy link
Contributor

#741 Removed border-radius on align left
Removed unused sections and

Removed border-radius when the thumbnail display is align left using thumbnailAlign prop and made thumbnail prop large.

Description

Issue addressed

Addresses #PR# HERE

Before/after screenshots

After Screenshots :
Screenshot 2024-08-24 at 6 43 33 PM

Changelog

  • [#PR no]
    • Description: Summary of change(s)
    • Products impact: Choose from - none (for internal updates) / bugfix / new API / updated API / removed API. If it's 'none', use "-" for all items below to indicate they are not relevant.
    • Addresses: Link(s) to GH issue(s) addressed. Include KDS links as well as links to related issues in a consumer product repository too.
    • Components: Affected public KDS component. Do not include internal sub-components or documentation components.
    • Breaking: Will this change break something in a consumer? Choose from: yes / no
    • Impacts a11y: Does this change improve a11y or adds new features that can be used to improve it? Choose from: yes / no
    • Guidance: Why and how to introduce this update to a consumer? Required for breaking changes, appreciated for changes with a11y impact, and welcomed for non-breaking changes when relevant.

[#PR no]: PR link

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • [ Yes ] The changelog item has been pasted to the CHANGELOG.md

Comments

spoorthy madasu added 2 commits August 26, 2024 23:15
Signed-off-by: spoorthy madasu <[email protected]>
@Spoorthy1423
Copy link
Contributor Author

Hey!! @AllanOXDi i was not able to commit my changes in issue-741-resolve so had to open another pr , so sorry besides changed as per commented!! Thank you

@MisRob
Copy link
Member

MisRob commented Aug 27, 2024

I'm sorry @Spoorthy1423, but this again has changes in package.json and yarn.lock that shouldn't be here, and were already cleared up. Let's finish in #754

@MisRob MisRob closed this Aug 27, 2024
@MisRob
Copy link
Member

MisRob commented Aug 27, 2024

i was not able to commit my changes in issue-741-resolve

@Spoorthy1423 If that's because @AllanOXDi pushed into your branch to help you, you could try to delete your local branch and then checkout it out again

@MisRob
Copy link
Member

MisRob commented Aug 27, 2024

@Spoorthy1423 By the way, it should be possible to just click "Commit suggestion" in GitHub UI. I also wanted to mention that we don't require contributors to complete the changelog, so I'm also fine doing that - feel free to let us know.

Just please respect the guidance we provided repeatedly and let's just communicate together instead of keeping opening tons of PRs, some of them having regressions in areas that were already reviewed previously. You don't need to be worried - we're glad to help with any blockers in your work in progress.

@AllanOXDi
Copy link
Member

AllanOXDi commented Aug 27, 2024

if that's because @AllanOXDi pushed into your branch to help you, you could try to delete your local branch and then checkout it out again.

@Spoorthy1423 I think you need to first pull the changes from your remote before pushing . And after updating the suggested changes you can push with --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants