Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component: Initial implementation of KCard component #625

Merged
merged 88 commits into from
Jul 19, 2024
Merged

New component: Initial implementation of KCard component #625

Show file tree
Hide file tree
Changes from 83 commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
91cae60
add kcard to kds
AllanOXDi Apr 23, 2024
584eece
add [data-focus=true] to handle card focus
AllanOXDi Apr 23, 2024
938d7f7
lint
AllanOXDi Apr 23, 2024
de928e9
KCard prop validation and handling tabbing through
AllanOXDi May 1, 2024
961bc5a
added spacing to the image
AllanOXDi May 1, 2024
2d26cbb
updates doc for KCard
AllanOXDi May 1, 2024
f0e4ceb
kcad documentation
AllanOXDi May 2, 2024
40b4aab
added prop linkage
AllanOXDi May 2, 2024
402e595
used semantic elements to wrap kcard content
AllanOXDi May 13, 2024
215ee75
added both layouts for testing the kcard in the playground component
AllanOXDi May 13, 2024
8641a75
updates doc
AllanOXDi May 15, 2024
76a1420
clean the KCard doc
AllanOXDi May 15, 2024
9d65d14
lint
AllanOXDi May 15, 2024
3e85253
change the path to lowercase
AllanOXDi May 18, 2024
bdfa21e
change the thumnail logic
AllanOXDi May 18, 2024
53b967f
revert semantic elements
AllanOXDi May 18, 2024
e6bc871
used css to display control card content display
AllanOXDi May 19, 2024
e41eae3
used themetoken color
AllanOXDi May 19, 2024
0e2b135
title displays in the correct section'
AllanOXDi May 19, 2024
6adf66f
added a comment to the data-focus=true
AllanOXDi May 19, 2024
7d0b2b6
removed unused image file
AllanOXDi May 19, 2024
c8abb15
added conditionalized image radius
AllanOXDi May 19, 2024
09a2595
cleaned overriding title text
AllanOXDi May 19, 2024
f8ead95
changes test suit case
AllanOXDi May 20, 2024
4f369a2
adds comments
AllanOXDi May 27, 2024
d177ff8
returned the header code to the basecard component
AllanOXDi May 31, 2024
07af751
checking content display
AllanOXDi May 31, 2024
c5ecb90
implement mousedown and mouseup for selecting text
AllanOXDi Jun 3, 2024
40a0d02
Error thrown when no title prop and title slot provided
AllanOXDi Jun 3, 2024
f3beb02
prevents routing when copying text
AllanOXDi Jun 3, 2024
4b9c05f
headerlevel value check
AllanOXDi Jun 3, 2024
177067e
added checks on props as per the specifications
AllanOXDi Jun 3, 2024
6215a36
thumbnail scale validation
AllanOXDi Jun 3, 2024
c038f09
fixes console errors on the kcard documentation page
AllanOXDi Jun 3, 2024
1ab7601
cleanedup the slot and prop description text on the kcard documentation
AllanOXDi Jun 3, 2024
b0f029b
adds more description on the kcard documentation
AllanOXDi Jun 6, 2024
d772fbb
fixes having wrong layouts passed as examples on the documentation page
AllanOXDi Jun 6, 2024
6b1106b
grammar clean up
AllanOXDi Jun 6, 2024
f6e49b1
test <li> element
AllanOXDi Jun 10, 2024
cd3a8bc
test correct accessibility structure
AllanOXDi Jun 10, 2024
f6d58cf
adds the footer to the extreme bottom in the horizontal layout and sm…
AllanOXDi Jun 11, 2024
b85931d
adds a fontsize to the above title
AllanOXDi Jun 12, 2024
f7c1b35
update the card
AllanOXDi Jun 12, 2024
2e4e627
work in progress
AllanOXDi Jun 12, 2024
3d4717a
rabese to develop
AllanOXDi Jun 17, 2024
69282d3
removes the border radius from vertical layout kimg
AllanOXDi Jun 17, 2024
98a819d
redesigned card content
AllanOXDi Jun 17, 2024
dd20433
adds spacing
AllanOXDi Jun 17, 2024
e9a3909
adds a border radius
AllanOXDi Jun 18, 2024
4c9b3d0
adds playground sample UI for all layouts
AllanOXDi Jun 18, 2024
cd44a98
lint
AllanOXDi Jun 18, 2024
99dc70a
lint
AllanOXDi Jun 18, 2024
d31f432
fixes js failure
AllanOXDi Jun 18, 2024
ca24ed3
fixes doc page
AllanOXDi Jun 18, 2024
2057fe4
rebase
AllanOXDi Jun 18, 2024
1764c5f
lint
AllanOXDi Jun 18, 2024
3e273b6
lint
AllanOXDi Jun 18, 2024
c553b87
renders the corect the markup
AllanOXDi Jun 20, 2024
3cc82b8
fixes verticle layouts
AllanOXDi Jun 20, 2024
cac41d9
uses flex to display kcard content
AllanOXDi Jun 28, 2024
4082a54
fixes indentation errors
AllanOXDi Jun 28, 2024
51ab712
conditionalize image slot appearance
AllanOXDi Jun 28, 2024
9364a1e
adds background color to the card
AllanOXDi Jun 29, 2024
bf60a04
fixes kcard responsiveness
AllanOXDi Jul 5, 2024
555151c
rebasing
AllanOXDi Jul 5, 2024
5013fba
removes unused test, functions and css classes
AllanOXDi Jul 12, 2024
4d5cb8a
passes slot at testing
AllanOXDi Jul 12, 2024
a43c1d3
fixes comments
AllanOXDi Jul 12, 2024
eb17031
card content placed at their position
AllanOXDi Jul 12, 2024
2c110f6
spacing
AllanOXDi Jul 12, 2024
1fe9fca
stablizes vertical layout display levels
AllanOXDi Jul 13, 2024
c091762
vertical small image spacing
AllanOXDi Jul 13, 2024
6b7d4cd
validation of the tile slot/prop
AllanOXDi Jul 13, 2024
b014297
Fix and cleanup title content and styles
MisRob Jul 16, 2024
1f27bec
Remove .pytest_cache files
MisRob Jul 16, 2024
2028f79
Add more documentation to BaseCard
MisRob Jul 16, 2024
3364c0a
Finish text selection feature
MisRob Jul 16, 2024
2a0a54b
Move a11y related validators to BaseCard
MisRob Jul 16, 2024
8936d13
Fix some tests, follow naming conventions
MisRob Jul 17, 2024
11b16e9
Several styling fixes, robust styling approach, re-organization of st…
MisRob Jul 17, 2024
edc6495
Make placeholders work
MisRob Jul 17, 2024
c315af7
Resolve changelog conflict
MisRob Jul 17, 2024
1e7d11a
Fix linter errors
MisRob Jul 17, 2024
d8cb4bc
Move comment
MisRob Jul 19, 2024
4a1a348
Document slots
MisRob Jul 19, 2024
3202ba3
Fix value type
MisRob Jul 19, 2024
6ef1abe
Remove obsolete styles
MisRob Jul 19, 2024
55b19ab
Cleanup playground
MisRob Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@ Changelog is rather internal in nature. See release notes for the public overvie

## Upcoming version 5.x.x (`develop` branch)

[#625]
- **Description:** Initial implementation of `KCard` component
- **Products impact:** New Component
- **Addresses:** [#530](https://github.com/learningequality/kolibri-design-system/issues/530)
- **Components:** KCard
- **Breaking:** No
- **Impacts a11y:** Yes
- **Guidance:**
[#625]: https://github.com/learningequality/kolibri-design-system/pull/625

- [#678]
- **Description:** Add `previewUnavailable` icon
- **Products impact:** new icon
Expand Down
Loading