Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the border-radius on align left #754

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Removed the border-radius on align left #754

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f4752af
Removed the border-radius on align left
Aug 26, 2024
f693a2c
Added some logic to keep borderRadius
Aug 26, 2024
6e9b26e
fixes lint
AllanOXDi Aug 27, 2024
cd60a91
Update CHANGELOG.md
Spoorthy1423 Aug 27, 2024
3d60c67
Update CHANGELOG.md
Spoorthy1423 Aug 27, 2024
6361230
Update CHANGELOG.md
Spoorthy1423 Aug 27, 2024
a3d91b2
Update CHANGELOG.md
Spoorthy1423 Aug 27, 2024
5aa3d5e
Update CHANGELOG.md
Spoorthy1423 Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ Changelog is rather internal in nature. See release notes for the public overvie

## Upcoming version 5.x.x (`develop` branch)

- [#741]
Spoorthy1423 marked this conversation as resolved.
Show resolved Hide resolved
- **Description:** Removed the border-radius on align left.
Spoorthy1423 marked this conversation as resolved.
Show resolved Hide resolved
- **Products impact:** -.
Spoorthy1423 marked this conversation as resolved.
Show resolved Hide resolved
- **Addresses:** -.
Spoorthy1423 marked this conversation as resolved.
Show resolved Hide resolved
- **Components:** -.
Spoorthy1423 marked this conversation as resolved.
Show resolved Hide resolved
- **Breaking:** no -.
- **Impacts a11y:** no -.
- **Guidance:** - Removed the border-radius on align left.
Spoorthy1423 marked this conversation as resolved.
Show resolved Hide resolved

[#741]: https://github.com/learningequality/kolibri-design-system/pull/751
Spoorthy1423 marked this conversation as resolved.
Show resolved Hide resolved

- [#650]
- **Description:** Add `KRadioButtonGroup` component to fix keyboard navigation in radio button groups in Firefox
- **Products impact:** New API
Expand Down
2 changes: 1 addition & 1 deletion lib/KCard/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@
},
thumbnailStyles: {
...thumbnailCommonStyles,
borderRadius: '8px 0 0 8px',
borderRadius: '0 8px 8px 0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Spoorthy1423 . Thanks for you work here. I have reviewed it and I think it's still breaking when it's align left.
Screenshot 2024-08-26 at 16 05 16

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will need to swap it when the thumbnail is on the right
borderRadius: '0 8px 8px 0',

And when the thumbnail is on the left
borderRadius: '8px 0 0 8px',

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we confirm that everything is looking good we will go a head and merge it.

},
};
}
Expand Down