Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin python version to 3.11 for node-gyp support. #12984

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Pin python version to 3.11 for node-gyp support. #12984

merged 1 commit into from
Jan 8, 2025

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 8, 2025

Summary

  • Pins Python version to 3.11 in our license check to allow node-gyp to work without additional dependencies.

@github-actions github-actions bot added the DEV: dev-ops Continuous integration & deployment label Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0a0.dev0_git.304.g09e6f0b0.pex
Windows Installer (EXE) kolibri-0.18.0a0.dev0+git.304.g09e6f0b0-windows-setup-unsigned.exe
Mac Installer (DMG) kolibri-0.18.0a0.dev0+git.304.g09e6f0b0.dmg
Android Package (APK) kolibri-0.18.0a0.dev0+git.304.g09e6f0b0-0.1.4-debug.apk
TAR file kolibri-0.18.0a0.dev0+git.304.g09e6f0b0.tar.gz
WHL file kolibri-0.18.0a0.dev0+git.304.g09e6f0b0-py2.py3-none-any.whl

nucleogenesis
nucleogenesis approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Richard

@nucleogenesis
Copy link
Member

When learningequality/kolibri-installer-debian#134 is merged, this PR's checks should be good to re-run for the build assets, ya?

@rtibbles
Copy link
Member Author

rtibbles commented Jan 8, 2025

The Debian build is not a required check, so we can merge regardless.

@rtibbles rtibbles merged commit ff51dfa into learningequality:develop Jan 8, 2025
36 of 37 checks passed
@rtibbles rtibbles deleted the license_check branch January 8, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis approved these changes

Assignees
No one assigned
Labels
DEV: dev-ops Continuous integration & deployment
Projects
None yet
Milestone
Kolibri 0.18: General maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @nucleogenesis